Gitup 2 review Patch#
This is not a valid reason to avoid creating patch series. It might be mentioned that Gerrit's handling of patch series is not entirely perfect.
Gitup 2 review code#
Ensure no-op code refactoring is done separately from functional changes. Ensure whitespace changes are not mixed in with functional changes. Look out for commits which are mixing multiple logical changes and require the submitter to split them into separate commits. Review the commit message itself and request improvements to its content. In other words, when reviewing a change in Gerrit, do not simply look at the correctness of the code. This document intends to be the carrot by alerting people to the benefits, while anyone doing Gerrit code review can act as the stick -P Both a carrot & stick will be required to effect changes. If these guidelines were widely applied it would result in a significant improvement in the quality of the OpenStack Git history. The points and examples that will be raised in this document ought to clearly demonstrate the value in splitting up changes into a sequence of individual commits, and the importance in writing good commit messages to go along with them.
The structured set/split of the code changes.This topic can be split into two areas of concern We can, however, come up with some general guidelines for what to do, or conversely what not to do, when publishing Git commits for merge with a project, in this case, OpenStack. Quality is a hard term to define in computing one person's "Thing of Beauty" is another's "Evil Hack". It is motivated by a desire to improve the quality of the Nova Git history. Examination of other open source projects such as the Kernel, CoreUtils, GNULIB and more suggested they all follow a fairly common practice. The following document is based on experience doing code development, bug troubleshooting and code review across a number of projects using Git, including libvirt, QEMU and OpenStack Nova. 1.3.2 Summary of Git commit message structure.1.2.1 Things to avoid when creating commits.
0 kommentar(er)
